Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Force close a completed Payment, #3

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

Elshaden
Copy link
Contributor

@Elshaden Elshaden commented Sep 8, 2024

Added a this.isCompleteCalled Flag,

This is needed when a the Transaction is completed, and the Moamalat Payment pop up, Lightbox is not closed after complete, The user will force close the Pop Up, causing the Cancel Event to fire. This will prevent this from happening.

Added a  this.isCompleteCalled Flag,

This is needed when a the Transaction is completed, and the Moamalat Payment pop up, Lightbox is not closed after complete, 
The user will force close the Pop Up, causing the Cancel Event to fire.
This will prevent this from happening.
@alifaraun alifaraun added the enhancement New feature or request label Sep 16, 2024
Copy link
Owner

@alifaraun alifaraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution , It’s a great idea.
However, I think it would be even better to make it configurable.
This would provide developers with more flexibility in how they use it.

@alifaraun alifaraun merged commit 94603d4 into alifaraun:main Sep 16, 2024
2 checks passed
@alifaraun
Copy link
Owner

I've updated it to enable_cancel_event_on_success in the config, with the default set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants